Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): open event not firing on init #7214

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

crisbeto
Copy link
Member

Fixes a regression that caused the drawer not to fire its open event if it is open on init.

Fixes #7208.

@crisbeto crisbeto requested a review from mmalerba as a code owner September 20, 2017 20:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 26, 2017
Fixes a regression that caused the drawer not to fire its `open` event if it is open on init.

Fixes angular#7208.
@crisbeto crisbeto force-pushed the 7208/drawer-onload-event branch from 0f42600 to d9c2523 Compare September 29, 2017 16:30
@andrewseguin andrewseguin merged commit ba5653d into angular:master Sep 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidenav fails to emit FIRST onClose event
4 participants