Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): incorrect green-500 contrast color #7492

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

devversion
Copy link
Member

As per the Material Design specifications, the 500-hue for the green palette should have a black (87% opacity) contrast color.

Reference: https://material.io/guidelines/style/color.html#color-color-palette

Fixes #7490

As per the Material Design specifications, the 500-hue for the green palette should have a black (87% opacity) contrast color.

Fixes angular#7490
@devversion devversion requested a review from jelbourn as a code owner October 3, 2017 12:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 3, 2017
@kara kara merged commit c1f6ea1 into angular:master Oct 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material green contrast color does not match material.io guidelines contrast color
5 participants