fix(datepicker): use disabled state from FormControl #7514
Conversation
googlebot
added
the
cla: yes
| @@ -147,7 +147,7 @@ export class MatDatepickerInput<D> implements AfterContentInit, ControlValueAcce | |||
|
|
|||
| /** Whether the datepicker-input is disabled. */ | |||
| @Input() | |||
| get disabled() { return this._disabled; } | |||
| get disabled() { return !!this._disabled; } | |||
There was a problem hiding this comment.
Just a question, is this (and some others in this PR) "coercion" really necessary? Isn't _disabled already being coerced in set disabled(...)?
There was a problem hiding this comment.
In most cases the coerceBooleanProperty would take care of it. Datepicker is a special case because of its cascading disabled state. We need to distinguish between never set and false to make this work.
There was a problem hiding this comment.
Aha, thanks for explaining :)
| @@ -44,39 +45,43 @@ export class MatDatepickerToggle<D> implements OnChanges, OnDestroy { | |||
| /** Whether the toggle button is disabled. */ | |||
| @Input() | |||
| get disabled() { | |||
| return this._disabled === undefined ? this.datepicker.disabled : this._disabled; | |||
| return this._disabled === undefined ? this.datepicker.disabled : !!this._disabled; | |||
There was a problem hiding this comment.
Shouldn't be this._disabled == null?
There was a problem hiding this comment.
So this disabled is never null? Because if disabled is null this comparison (null === undefined) won't work.
There was a problem hiding this comment.
coerceBooleanProperty will make sure its never null. The only reason it can be undefined is because we don't set an initial value for _disabled, so if there's no property binding for disabled the setter is never called and it remains undefined
crisbeto
added
pr: lgtm
action: merge
|
@mmalerba Rebase? |
kara
added
pr: needs rebase
and removed
action: merge
mmalerba
force-pushed
the
dp-fc-disabled
branch
from
f8c5a19 to
450389e
Compare
mmalerba
added
action: merge
|
done |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes #6973