Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[overlay] close scroll strategy not properly detaching from DOM #7922

Closed
willshowell opened this issue Oct 20, 2017 · 1 comment · Fixed by #7929
Closed

[overlay] close scroll strategy not properly detaching from DOM #7922

willshowell opened this issue Oct 20, 2017 · 1 comment · Fixed by #7929
Assignees
@crisbeto

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the current behavior?

Using CloseScrollStrategy, scrolling calls detach on the OverlayRef, but it isn't removed from the DOM.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue-6yqwge

cc @crisbeto
@willshowell willshowell mentioned this issue Oct 20, 2017
Merged
@crisbeto crisbeto self-assigned this Oct 20, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 21, 2017
@crisbeto
fix(overlay): emitting to detachments stream when not attached
6e492c1 
Currently the `detachments` stream will emit any time the `detach` or `dispose` methods are called, which doesn't reflect actual detachments. It is something I noticed while looking into angular#7922.
@crisbeto crisbeto mentioned this issue Oct 21, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 21, 2017
@crisbeto
fix(overlay): CloseScrollStrategy not triggering change detection on …
0540592 
…close

After some refactoring, the `ScrollDispatcher` no longer dispatches inside the `NgZone`, which caused the `CloseScrollStrategy` to break, because it detaches without triggering change detection. These changes bring the detachment back into the `NgZone`.

Fixes angular#7922.
This was referenced Oct 21, 2017
Merged
Closed
andrewseguin pushed a commit that referenced this issue Nov 2, 2017
@crisbeto @andrewseguin
fix(overlay): emitting to detachments stream when not attached (#7944)
6fdc237 
Currently the `detachments` stream will emit any time the `detach` or `dispose` methods are called, which doesn't reflect actual detachments. It is something I noticed while looking into #7922.
andrewseguin pushed a commit that referenced this issue Nov 2, 2017
@crisbeto @andrewseguin
fix(overlay): CloseScrollStrategy not triggering change detection on …
c0ba25a 
…close (#7929)

After some refactoring, the `ScrollDispatcher` no longer dispatches inside the `NgZone`, which caused the `CloseScrollStrategy` to break, because it detaches without triggering change detection. These changes bring the detachment back into the `NgZone`.

Fixes #7922.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(overlay): CloseScrollStrategy not triggering change detection on close crisbeto/material2
2 participants
@crisbeto @willshowell