Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user-select mixin ignores value #7992

Merged
merged 1 commit into from
Nov 2, 2017
Merged

fix: user-select mixin ignores value #7992

merged 1 commit into from
Nov 2, 2017

Conversation

devversion
Copy link
Member

  • Fixes that the $value parameter for the user-select mixin from core is ignored.

@devversion
fix: user-select mixin ignores value
5d60dd3 
* Fixes that the `$value` parameter for the `user-select` mixin from core is ignored.
@devversion devversion requested a review from jelbourn as a code owner October 24, 2017 10:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 24, 2017
crisbeto
crisbeto approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 24, 2017
jelbourn
jelbourn approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit eaa4a36 into angular:master Nov 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

@crisbeto crisbeto

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devversion @jelbourn @crisbeto @googlebot @mmalerba @andrewseguin