Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow disableRipple on mat-menu-item buttons #8261

Closed
ilovett opened this issue Nov 6, 2017 · 2 comments · Fixed by #8388
Closed

allow disableRipple on mat-menu-item buttons #8261

ilovett opened this issue Nov 6, 2017 · 2 comments · Fixed by #8388
Assignees
@devversion
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions

Comments

@ilovett
Copy link

ilovett commented Nov 6, 2017

Bug, feature request, or proposal:

bug/feature

What is the expected behavior?

ability to disableRipple on mat-menu-item

What is the current behavior?

Ripples no matter what

What are the steps to reproduce?

Is it just me or are all the plunker's for material broken atm?

What is the use-case or motivation for changing an existing behavior?

Slowly migrating existing UI styling to Material styling, or maybe i just don't like the ripple?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

angular 4.4.6
material 2.0.0-beta12

Is there anything else we should know?
@julianobrasil
Copy link
Contributor

Try stackblitz.com: https://stackblitz.com/edit/dialog-issue

@josephperrott josephperrott added feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions labels Nov 9, 2017
@devversion devversion self-assigned this Nov 11, 2017
devversion added a commit to devversion/material2 that referenced this issue Nov 12, 2017
@devversion
feat(menu-item): allow disabling ripples
fdac66b 
* Allows disabling ripples for specific menu items.

Closes angular#8261
devversion added a commit to devversion/material2 that referenced this issue Nov 12, 2017
@devversion
feat(menu-item): allow disabling ripples
6780106 
* Allows disabling ripples for specific menu items.

Closes angular#8261
@devversion devversion mentioned this issue Nov 12, 2017
Merged
jelbourn pushed a commit that referenced this issue Nov 18, 2017
@devversion @jelbourn
feat(menu-item): allow disabling ripples
ecccadf 
* Allows disabling ripples for specific menu items.

Closes #8261
devversion added a commit to devversion/material2 that referenced this issue Nov 19, 2017
@devversion
feat(menu-item): allow disabling ripples
69ca195 
* Allows disabling ripples for specific menu items.

Closes angular#8261
jelbourn pushed a commit that referenced this issue Nov 20, 2017
@devversion @jelbourn
feat(menu): allow disabling ripples on items (#8388)
ce23395 
Closes #8261
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(menu-item): allow disabling ripples devversion/material2
4 participants
@ilovett @devversion @josephperrott @julianobrasil