Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): inaccurate row height #8303

Merged
merged 1 commit into from
Jan 12, 2018
Merged

fix(table): inaccurate row height #8303

merged 1 commit into from
Jan 12, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 8, 2017

Fixes the table border throwing of the table row height by one pixel.

Fixes #8299.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 8, 2017
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 16, 2017
@jelbourn
Copy link
Member

@crisbeto lint error:

src/material-examples/table-selection/table-selection-example.css
 14:3  ✖  The `initial` value is not supported in IE  declaration-property-value-blacklist

@jelbourn
Copy link
Member

Nvm, not this PR. Weird error.

@crisbeto
Copy link
Member Author

AFAIK I opened this one while we had some lint errors in master.

@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 20, 2017
@jelbourn
Copy link
Member

Caretaker note: causes a fair number of screenshot changes, need to decide if this would be considered breaking

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jan 12, 2018
@andrewseguin
Copy link
Contributor

andrewseguin commented Jan 12, 2018 •
edited
Loading

Manually merged in a previous commit to rebase - @crisbeto can you confirm it looks right

@crisbeto
fix(table): inaccurate row height
af5c02a 
Fixes the table border throwing of the table row height by one pixel.

Fixes angular#8299.
@crisbeto crisbeto force-pushed the 8299/table-row-height branch from 82281ec to af5c02a Compare January 12, 2018 16:19
@crisbeto crisbeto added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jan 12, 2018
@angular angular deleted a comment from googlebot Jan 12, 2018
@andrewseguin andrewseguin merged commit baa8a6e into angular:master Jan 12, 2018
andrewseguin pushed a commit that referenced this pull request Jan 12, 2018
@crisbeto @andrewseguin
fix(table): inaccurate row height (#8303)
1254353 
Fixes the table border throwing of the table row height by one pixel.

Fixes #8299.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(table): divider should sit within the baseline
4 participants
@crisbeto @jelbourn @andrewseguin @googlebot