Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow missing in opened mat-sidenav #8386

Closed
Plondrein opened this issue Nov 12, 2017 · 1 comment · Fixed by #8387
Closed

shadow missing in opened mat-sidenav #8386

Plondrein opened this issue Nov 12, 2017 · 1 comment · Fixed by #8387
Assignees

Comments

@Plondrein
Copy link
Contributor

Bug, feature request, or proposal:

Bug/Regression from 2.0.0-beta.8.

What is the expected behavior?

After opening sidenav , mat-sidenav element should contain 'mat-drawer-opened' class, which is responsible for shadow:

  &.mat-drawer-opening, &.mat-drawer-opened {
    &:not(.mat-drawer-side) {
      // The elevation of z-16 is noted in the design specifications.
      // See https://material.io/guidelines/patterns/navigation-drawer.html#
      @include mat-elevation(16);
    }
  }

from drawer.scss

What is the current behavior?

Opened sidenav doesn't contain such class and there is no shadow in result.

What are the steps to reproduce?

The bug is right in Basic sidenav example,
only when you add manually 'mat-drawer-opened' shadow appears.

Turn off backdrop for better visiblity:

.mat-drawer-backdrop.mat-drawer-shown {
    visibility: hidden;
}

https://material.angular.io/components/sidenav/overview

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Chrome 62.0.3202.89
Windows 10
material-beta.12
angular 4.4.6

@crisbeto crisbeto self-assigned this Nov 12, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 12, 2017
Fixes the elevation box shadow not being applied to drawers.

Fixes angular#8386.
jelbourn pushed a commit that referenced this issue Nov 18, 2017
Fixes the elevation box shadow not being applied to drawers.

Fixes #8386.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 19, 2017
Fixes the elevation box shadow not being applied to drawers.

Fixes angular#8386.
jelbourn pushed a commit that referenced this issue Nov 20, 2017
Fixes the elevation box shadow not being applied to drawers.

Fixes #8386
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants