fix(overlay): onPositionChange stream not being completed #8562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
overlay-complete-change-event
branch
from
13d8d30 to
20c4241
Compare
|
Can you check the CI error |
andrewseguin
added
the
presubmit failures
crisbeto
force-pushed
the
overlay-complete-change-event
branch
from
20c4241 to
3c7526a
Compare
crisbeto
removed
the
presubmit failures
|
The CI failures are coming in from master. |
crisbeto
force-pushed
the
overlay-complete-change-event
branch
from
3c7526a to
19301d0
Compare
crisbeto
force-pushed
the
overlay-complete-change-event
branch
from
19301d0 to
9a263d6
Compare
|
@crisbeto The Travis failure is a real failure: no variable |
crisbeto
removed
action: merge
Completes the `onPositionChange` stream when the position strategy is disposed. Also cleans up a few cases that were unsubscribing from it explicitly.
crisbeto
force-pushed
the
overlay-complete-change-event
branch
from
9a263d6 to
5678c08
Compare
crisbeto
added
action: merge
|
Fixed @tinayuangao. Seems like I made a mistake while rebasing. |
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 1, 2018
Completes the `onPositionChange` stream when the position strategy is disposed. Also cleans up a few cases that were unsubscribing from it explicitly.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the
onPositionChangestream when the position strategy is disposed. Also cleans up a few cases that were unsubscribing from it explicitly.