Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): not closing when scrolling away #8688

Merged
merged 1 commit into from
Dec 8, 2017
Merged

fix(tooltip): not closing when scrolling away #8688

merged 1 commit into from
Dec 8, 2017

Conversation

crisbeto
Copy link
Member

Fixes the tooltip not being closed when scrolling away due to the onPositionChange being executed outside the NgZone after some changes to the ScrollDispatcher.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 28, 2017
andrewseguin
andrewseguin approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 29, 2017
@crisbeto
fix(tooltip): not closing when scrolling away
7bc5e50 
Fixes the tooltip not being closed when scrolling away due to the `onPositionChange` being executed outside the `NgZone` after some changes to the `ScrollDispatcher`.
@crisbeto crisbeto force-pushed the tooltip-scroll-ngzone branch from 0366397 to 7bc5e50 Compare December 2, 2017 10:20
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
@mmalerba mmalerba merged commit d5a2fca into angular:master Dec 8, 2017
mmalerba pushed a commit that referenced this pull request Dec 8, 2017
@crisbeto @mmalerba
fix(tooltip): not closing when scrolling away (#8688)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e96a847 
Fixes the tooltip not being closed when scrolling away due to the `onPositionChange` being executed outside the `NgZone` after some changes to the `ScrollDispatcher`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @andrewseguin @googlebot @mmalerba