-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Expansion] Arrow animation missing in 5.0.5 #8814
Comments
animation doesn't work with @angular/animations @5.0.5 (see https://stackblitz.com/angular/xkgonrebbpl) |
This looks like a regression in 5.0.5. There are couple of other animations that don't work correctly (the fade in on |
This is actually the result of an upstream bug here: angular/angular#20946 |
Actually, I think this is because the parent animation block the child animation. In this case, the [@expansionHeight] (parent animation) blocks the [@indicatorRotate] (child animation). |
I have already used animateChild() to fix it. How could I pull the request? |
Thanks for the heads-up @DanielYKPan. I've submitted a PR since there are a couple more components that have similar issues. |
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes angular#8814, angular#8953.
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes angular#8814. Fixes angular#8953.
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes angular#8814. Fixes angular#8953.
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes #8814. Fixes #8953.
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes angular#8814. Fixes angular#8953.
Will there be some way to add animations to custom-elements that are used in projected content, for example in a Usecase is, that I added a customized expaned-indicator that uses its own animation. This worked up until |
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes angular#8814. Fixes angular#8953.
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes #8814. Fixes #8953.
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes #8814. Fixes #8953.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
Rotation animation of the arrow in mat-expansion-panel-header.
What is the current behavior?
Arrow on the right of the mat-expansion-panel-header doesn't animates.
What are the steps to reproduce?
http://plnkr.co/edit/zIEeYb?p=preview
What is the use-case or motivation for changing an existing behavior?
Animation was working in previous version.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
all including Angular Material 5.0.0-rc.1
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: