Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expansion] Arrow animation missing in 5.0.5 #8814

Closed
nicolasguilhem opened this issue Dec 5, 2017 · 8 comments · Fixed by #9134
Closed

[Expansion] Arrow animation missing in 5.0.5 #8814

nicolasguilhem opened this issue Dec 5, 2017 · 8 comments · Fixed by #9134
Assignees
Labels
animation This issue is related to Angular animations or CSS animations blocked This issue is blocked by some external factor, such as a prerequisite PR P2 The issue is important to a large percentage of users, with a workaround

Comments

@nicolasguilhem
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Rotation animation of the arrow in mat-expansion-panel-header.

What is the current behavior?

Arrow on the right of the mat-expansion-panel-header doesn't animates.

What are the steps to reproduce?

http://plnkr.co/edit/zIEeYb?p=preview

What is the use-case or motivation for changing an existing behavior?

Animation was working in previous version.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

all including Angular Material 5.0.0-rc.1

Is there anything else we should know?

@nicolasguilhem
Copy link
Author

animation doesn't work with @angular/animations @5.0.5 (see https://stackblitz.com/angular/xkgonrebbpl)
animation works with @angular/animations @4.4.6 (see https://stackblitz.com/edit/angular-y2h6b6)

@crisbeto
Copy link
Member

crisbeto commented Dec 5, 2017

This looks like a regression in 5.0.5. There are couple of other animations that don't work correctly (the fade in on mat-select and mat-menu). The issue seems to happen on elements with multiple running animations at the same time.

@andrewseguin andrewseguin changed the title missing rotation animation of the arrow in mat-expansion-panel-header [Expansion] Arrow animation missing in 5.0.5 Dec 12, 2017
@josephperrott
Copy link
Member

This is actually the result of an upstream bug here: angular/angular#20946

@josephperrott josephperrott added animation This issue is related to Angular animations or CSS animations blocked P2 The issue is important to a large percentage of users, with a workaround labels Dec 15, 2017
@DanielYKPan
Copy link

DanielYKPan commented Dec 27, 2017

Actually, I think this is because the parent animation block the child animation.
According to Angular Doc, Each time an animation is triggered in angular, the parent animation will always get priority and any child animations will be blocked.

In this case, the [@expansionHeight] (parent animation) blocks the [@indicatorRotate] (child animation).

@DanielYKPan
Copy link

I have already used animateChild() to fix it. How could I pull the request?

@crisbeto
Copy link
Member

Thanks for the heads-up @DanielYKPan. I've submitted a PR since there are a couple more components that have similar issues.

crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 27, 2017
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814, angular#8953.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 27, 2017
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
@crisbeto crisbeto self-assigned this Dec 27, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 8, 2018
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
jelbourn pushed a commit that referenced this issue Jan 21, 2018
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 23, 2018
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
@ClemensSchneider
Copy link

Will there be some way to add animations to custom-elements that are used in projected content, for example in a <mat-expansion-panel-header> element?

Usecase is, that I added a customized expaned-indicator that uses its own animation. This worked up until @angular/animations 5.0.2 and is broke since 5.0.3.

crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 17, 2018
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
andrewseguin pushed a commit that referenced this issue Feb 20, 2018
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.
tinayuangao pushed a commit that referenced this issue Feb 20, 2018
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
@mmalerba mmalerba added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
animation This issue is related to Angular animations or CSS animations blocked This issue is blocked by some external factor, such as a prerequisite PR P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants