Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): avoid initial animation when rendering on the server #8828

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 5, 2017

Prevents drawers that are open by default from animating on init if they're rendered on the server.

Fixes #6865.

@crisbeto crisbeto requested a review from mmalerba as a code owner December 5, 2017 20:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2017
Prevents drawers that are open by default from animating on init if they're rendered on the server.

Fixes angular#6865.
@crisbeto crisbeto force-pushed the 6865/drawer-universal-animation branch from d159ad0 to cb411d3 Compare December 5, 2017 20:10
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 5, 2017
@mmalerba mmalerba added this to the 5.0 milestone Dec 5, 2017
@mmalerba mmalerba merged commit 2b1f84e into angular:master Dec 5, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Md-Sidenav open mode bootstrap animation
3 participants