Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): being able to focus disabled chip by clicking #8892

Merged
merged 1 commit into from
Jan 4, 2018
Merged

fix(chips): being able to focus disabled chip by clicking #8892

merged 1 commit into from
Jan 4, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 8, 2017

Fixes users being able to focus a disabled chip by clicking it.

Fixes #8883.

@crisbeto
fix(chips): being able to focus disabled chip by clicking
0c62149 
Fixes users being able to focus a disabled chip by clicking it.

Fixes angular#8883.
@crisbeto crisbeto requested a review from tinayuangao as a code owner December 8, 2017 19:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 8, 2017
tinayuangao
tinayuangao approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Dec 19, 2017
@jelbourn jelbourn merged commit bfd513d into angular:master Jan 4, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
@crisbeto @jelbourn
fix(chips): being able to focus disabled chip by clicking (angular#8892)
699b7c2 
Fixes users being able to focus a disabled chip by clicking it.

Fixes angular#8883.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
@crisbeto @jelbourn
fix(chips): being able to focus disabled chip by clicking (angular#8892)
3709672 
Fixes users being able to focus a disabled chip by clicking it.

Fixes angular#8883.
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
@crisbeto @jelbourn
fix(chips): being able to focus disabled chip by clicking (#8892)
70c75ea 
Fixes users being able to focus a disabled chip by clicking it.

Fixes #8883.
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
@crisbeto @tinayuangao
fix(chips): being able to focus disabled chip by clicking (#8892)
115f95c 
Fixes users being able to focus a disabled chip by clicking it.

Fixes #8883.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled MatChips styles differ from documentation
4 participants
@crisbeto @tinayuangao @jelbourn @googlebot