fix(select): don't restore focus unless an option was selected #8964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
Needs rebase |
crisbeto
force-pushed
the
8915/select-restore-focus
branch
from
4c6210d to
3941bf2
Compare
crisbeto
added
target: patch
jelbourn
reviewed
Jan 4, 2018
src/lib/select/select.ts
Outdated
| /** Whether the select is focused. */ | ||
| focused = false; | ||
| get focused() { |
There was a problem hiding this comment.
Uncovered during presubmit: this makes focused readonly, which is a breaking change
(apparently some apps set it manually for some reason)
crisbeto
force-pushed
the
8915/select-restore-focus
branch
from
3941bf2 to
c2976d4
Compare
|
Reverted the breaking change @jelbourn. |
Currently `mat-select` always restores focus to its trigger whenever the panel is closed. This can be problematic, because the user might've scrolled away and restoring focus would scroll the page back up. These changes switch to only restoring focus if the user made a selection. Fixes angular#8915.
crisbeto
force-pushed
the
8915/select-restore-focus
branch
from
c2976d4 to
52b5740
Compare
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
…ar#8964) Currently `mat-select` always restores focus to its trigger whenever the panel is closed. This can be problematic, because the user might've scrolled away and restoring focus would scroll the page back up. These changes switch to only restoring focus if the user made a selection. Fixes angular#8915.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
mat-selectalways restores focus to its trigger whenever the panel is closed. This can be problematic, because the user might've scrolled away and restoring focus would scroll the page back up. These changes switch to only restoring focus if the user made a selection.Fixes #8915.