Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typography): deprecation warning if null font family is passed in #9002

Merged
merged 1 commit into from
Jan 4, 2018
Merged

fix(typography): deprecation warning if null font family is passed in #9002

merged 1 commit into from
Jan 4, 2018

Conversation

crisbeto
Copy link
Member

  • Fixes a deprecation warning that gets logged by mat-font-family if the consumer passes in null as the font-family.
  • Adds better handling if any of the typography properties are null.

Fixes #8973.

@crisbeto
fix(typography): deprecation warning if null font family is passed in
fb13542 
* Fixes a deprecation warning that gets logged by `mat-font-family` if the consumer passes in `null` as the `font-family`.
* Adds better handling if any of the typography properties are null.

Fixes angular#8973.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 14, 2017
jelbourn
jelbourn approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 14, 2017
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 16, 2017
@jelbourn jelbourn merged commit d8c1392 into angular:master Jan 4, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
@crisbeto @jelbourn
fix(typography): deprecation warning if null font family is passed in (…
497816b 
…angular#9002)

* Fixes a deprecation warning that gets logged by `mat-font-family` if the consumer passes in `null` as the `font-family`.
* Adds better handling if any of the typography properties are null.

Fixes angular#8973.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
@crisbeto @jelbourn
fix(typography): deprecation warning if null font family is passed in (…
fcaa3c4 
…angular#9002)

* Fixes a deprecation warning that gets logged by `mat-font-family` if the consumer passes in `null` as the `font-family`.
* Adds better handling if any of the typography properties are null.

Fixes angular#8973.
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
@crisbeto @jelbourn
fix(typography): deprecation warning if null font family is passed in (…
04411ea 
…#9002)

* Fixes a deprecation warning that gets logged by `mat-font-family` if the consumer passes in `null` as the `font-family`.
* Adds better handling if any of the typography properties are null.

Fixes #8973.
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
@crisbeto @tinayuangao
fix(typography): deprecation warning if null font family is passed in (…
b1669d4 
…#9002)

* Fixes a deprecation warning that gets logged by `mat-font-family` if the consumer passes in `null` as the `font-family`.
* Adds better handling if any of the typography properties are null.

Fixes #8973.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warnings in _theming.scss
3 participants
@crisbeto @jelbourn @googlebot