Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatButtonToggleGroupMultiple lacks value property and change event #9058

Closed
chriszrc opened this issue Dec 19, 2017 · 1 comment · Fixed by #9191
Closed

MatButtonToggleGroupMultiple lacks value property and change event #9058

chriszrc opened this issue Dec 19, 2017 · 1 comment · Fixed by #9191
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions

Comments

@chriszrc
Copy link

Feature request:

The docs clearly indicate that when using the MatButtonToggleGroup with the multiple directive, that you can no longer access the values of the control. While that is very informative, it makes the multiple variant of this control almost entirely unusable in a form. Without a change event or a value, you have to hack in things like click events just to get the selected values.

What is the expected behavior?

The MatButtonToggleGroupMultiple class should ideally inherit all of the functionality currently in the MatButtonToggleGroup class

What is the current behavior?

Currently, it inherits practically none of it.

What is the use-case or motivation for changing an existing behavior?

Without being able to easily access the selected values, how are we supposed to use these in our forms?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material 5.0.1

Is there anything else we should know?
@josephperrott josephperrott added feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions labels Dec 19, 2017
@crisbeto crisbeto self-assigned this Jan 2, 2018
@crisbeto crisbeto added the has pr label Jan 2, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 2, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
9c2e667 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 2, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
ce873ae 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
@crisbeto crisbeto mentioned this issue Jan 2, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 3, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
8af2daf 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 10, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
2a27883 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
jelbourn pushed a commit that referenced this issue Jan 21, 2018
@crisbeto @jelbourn
feat(button-toggle): general component cleanup and support value inpu…
1b3b35f 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as #2773, however #2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes #9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 22, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
3cacceb 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 26, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
4619d4b 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 3, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
e7f04df 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 19, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
81d63df 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 20, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
7158d0e 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 25, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
6ff097d 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 12, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
c5da822 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 12, 2018
@crisbeto
feat(button-toggle): general component cleanup and support value inpu…
79fcf6c 
…t in multiple mode

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as angular#2773, however angular#2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes angular#9058.
mmalerba pushed a commit that referenced this issue Mar 13, 2018
@crisbeto @mmalerba
feat(button-toggle): general component cleanup and support value inpu…
a403bac 
…t in multiple mode (#9191)

* Reworks the `MatButtonToggleGroup` component to remove the need for the `MatButtonToggleGroupMultiple` component and to avoid having to implement features in two places.
* Reworks the `MatButtonToggleGroup` to use the `SelectionModel` for managing its state.
* Switches all of the `async` button toggle tests to run in `fakeAsync`.

As a side-effect of the above-mentioned changes, the toggle group in multiple mode now supports the same inputs as the one in single-selection mode (`value` input/output, `name` input, `change` event etc.).

Note: this is along the same lines as #2773, however #2773 got left behind for too long and it would need a lot more work to fit in our current setup.

Fixes #9058.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
3 participants
@crisbeto @josephperrott @chriszrc