Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(selection-list): options not marked as selected if value is assigned too early #9090

Merged
merged 1 commit into from
Jan 4, 2018
Merged

fix(selection-list): options not marked as selected if value is assigned too early #9090

merged 1 commit into from
Jan 4, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 21, 2017 •
edited
Loading

Fixes the selection list options not being marked as selected if the component's value is set before ngAfterContentInit.

Fixes #9085.

@crisbeto
fix(selection-list): options not marked as selected if value is assig…
0e7e252 
…ned too early

Fixes the selection list options not being marked as selected if the component's value is set before `ngAfterContentInit`.

Fixes angular#9085.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 21, 2017
@crisbeto crisbeto changed the title fix(selection-list): options not marked as selected if value is assig… fix(selection-list): options not marked as selected if value is assigned too early Dec 21, 2017
devversion
devversion approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 21, 2017
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 22, 2017
jelbourn
jelbourn approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit bd7c751 into angular:master Jan 4, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
@crisbeto @jelbourn
fix(selection-list): options not marked as selected if value is assig…
c61a289 
…ned too early (angular#9090)

Fixes the selection list options not being marked as selected if the component's value is set before `ngAfterContentInit`.

Fixes angular#9085.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
@crisbeto @jelbourn
fix(selection-list): options not marked as selected if value is assig…
69de7df 
…ned too early (angular#9090)

Fixes the selection list options not being marked as selected if the component's value is set before `ngAfterContentInit`.

Fixes angular#9085.
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
@crisbeto @jelbourn
fix(selection-list): options not marked as selected if value is assig…
38481c6 
…ned too early (#9090)

Fixes the selection list options not being marked as selected if the component's value is set before `ngAfterContentInit`.

Fixes #9085.
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
@crisbeto @tinayuangao
fix(selection-list): options not marked as selected if value is assig…
ec56cb2 
…ned too early (#9090)

Fixes the selection list options not being marked as selected if the component's value is set before `ngAfterContentInit`.

Fixes #9085.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-selection-list list-options don't update when formControl for mat-selection-list is updated with setValue
4 participants
@crisbeto @jelbourn @devversion @googlebot