Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenav: mat-sidenav-content margins not updated when dir changed #9158

Closed
langan opened this issue Dec 29, 2017 · 1 comment · Fixed by #9161
Closed

Sidenav: mat-sidenav-content margins not updated when dir changed #9158

langan opened this issue Dec 29, 2017 · 1 comment · Fixed by #9161
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@langan
Copy link

langan commented Dec 29, 2017

Bug, feature request, or proposal:

Bug: mat-sidenav-content margins are not updated when text direction changes

What is the expected behavior?

When you switch to RTL or back to LTR the margins of mat-sidenav-content should be recalculates.

What is the current behavior?

When you change the text direction to RTL mat-sidenav-content keeps the LTR margins

What are the steps to reproduce?

https://stackblitz.com/edit/angular-ysmyrn

What is the use-case or motivation for changing an existing behavior?

Switching from LTR / RTL shouldn't require a reload of the page.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular: 5.0.0
Angular Material: 5.0.2

Is there anything else we should know?

Looking at this line https://github.com/angular/material2/blob/c3d7cd96de6f06e1530658e41d1e8aa3ba74805e/src/lib/sidenav/drawer.ts#L493 maybe we should also call _updateContentMargins ?
@crisbeto crisbeto self-assigned this Dec 29, 2017
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Dec 29, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 29, 2017
@crisbeto
fix(drawer): margins not being updated on direction changes
0edf4c1 
Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes angular#9158.
@crisbeto crisbeto mentioned this issue Dec 29, 2017
Merged
jelbourn pushed a commit that referenced this issue Jan 4, 2018
@crisbeto @jelbourn
fix(drawer): margins not being updated on direction changes (#9161)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ff1c5f1 
Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes #9158.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 8, 2018
@crisbeto @jelbourn
fix(drawer): margins not being updated on direction changes (angular#…
f64a857 
…9161)

Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes angular#9158.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 9, 2018
@crisbeto @jelbourn
fix(drawer): margins not being updated on direction changes (angular#…
f81f5c7 
…9161)

Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes angular#9158.
jelbourn pushed a commit that referenced this issue Jan 9, 2018
@crisbeto @jelbourn
fix(drawer): margins not being updated on direction changes (#9161)
0217f9e 
Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes #9158.
tinayuangao pushed a commit that referenced this issue Jan 10, 2018
@crisbeto @tinayuangao
fix(drawer): margins not being updated on direction changes (#9161)
883e184 
Fixes the `mat-drawer-container` margins not being updated when its directionality has changed.

Fixes #9158.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(drawer): margins not being updated on direction changes crisbeto/material2
2 participants
@langan @crisbeto