Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): prevent list icon shrinking #9211

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

devversion
Copy link
Member

  • Since the list-item uses flexbox, it can happen that the matListIcon shrinks to make place for the mat-list-text. Similar as for the matListAvatar shrinking should be disabled for the matListIcon.

Fixes #8699

* Since the list-item uses flexbox, it can happen that the `matListIcon` shrinks to make place for the `mat-list-text`. Similar as for the `matListAvatar` shrinking should be disabled for the `matListIcon`.

Fixes angular#8699
@devversion devversion added pr: needs review target: patch This PR is targeted for the next patch release labels Jan 3, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 3, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 3, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 5737b9f into angular:master Jan 12, 2018
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Jan 12, 2018
* Since the list-item uses flexbox, it can happen that the `matListIcon` shrinks to make place for the `mat-list-text`. Similar as for the `matListAvatar` shrinking should be disabled for the `matListIcon`.

Fixes angular#8699
andrewseguin pushed a commit that referenced this pull request Jan 17, 2018
* Since the list-item uses flexbox, it can happen that the `matListIcon` shrinks to make place for the `mat-list-text`. Similar as for the `matListAvatar` shrinking should be disabled for the `matListIcon`.

Fixes #8699
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mat-icon height/width styles not specific enough
5 participants