Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat-stepper [optional] not working / broken #9239

Closed
ztgluis opened this issue Jan 4, 2018 · 1 comment · Fixed by #9245
Closed

mat-stepper [optional] not working / broken #9239

ztgluis opened this issue Jan 4, 2018 · 1 comment · Fixed by #9245
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@ztgluis
Copy link

ztgluis commented Jan 4, 2018

Bug: Setting a step to Optional is not working correctly when containing a form with validators

What is the expected behavior?

Should be able to continue through a optional step if a form is not completed but set as optional.

What is the current behavior?

Can't continue past an optional step without filling the form.

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

Version 5.0.1 of Material was working as described/expected, upgrading to 5.0.3 breaks this functionality rendering the 'optional' property useless.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Tested on Angular 5.1.3, Material 5.0.3

Is there anything else we should know?

Worked as expected in Material 5.0.1
I believe the issue was introduces by this PR:
#8646

@crisbeto crisbeto self-assigned this Jan 5, 2018
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jan 5, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 5, 2018
Fixes users not being allowed to skip optional invalid steps inside of a linear stepper.

Fixes angular#9239.
jelbourn pushed a commit that referenced this issue Jan 21, 2018
Fixes users not being allowed to skip optional invalid steps inside of a linear stepper.

Fixes #9239.
jelbourn pushed a commit that referenced this issue Jan 23, 2018
Fixes users not being allowed to skip optional invalid steps inside of a linear stepper.

Fixes #9239.
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 29, 2018
…r#9245)

Fixes users not being allowed to skip optional invalid steps inside of a linear stepper.

Fixes angular#9239.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants