Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): floating label not reacting when patching the value without emitting an event #9260

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 6, 2018

Fixes the input's floating label state not being updated when the consumer patches the form control's value without emitting an event.

Fixes #8982.

…ut emitting an event

Fixes the input's floating label state not being updated when the consumer patches the form control's value without emitting an event.

Fixes angular#8982.
@crisbeto crisbeto requested a review from mmalerba as a code owner January 6, 2018 16:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 6, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Jan 8, 2018
@jelbourn jelbourn merged commit ec6678d into angular:master Jan 23, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
…ut emitting an event (angular#9260)

Fixes the input's floating label state not being updated when the consumer patches the form control's value without emitting an event.

Fixes angular#8982.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Input] Placeholder not hidden when formControl value changes with emitEvent: false
4 participants