Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(selection-model): incorrect initial value when empty array is passed in single-selection mode #9287

Merged
merged 1 commit into from
Jan 23, 2018
Merged

fix(selection-model): incorrect initial value when empty array is passed in single-selection mode #9287

merged 1 commit into from
Jan 23, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 8, 2018

  • Fixes the selection model being initialized to [undefined] when an empty array is passed in as the initial value in single-selection mode.
  • Minor cleanup.

Fixes #9273.

@crisbeto
fix(selection-model): incorrect initial value when empty array is pas…
2285f8e 
…sed in single-selection mode

* Fixes the selection model being initialized to `[undefined]` when an empty array is passed in as the initial value in single-selection mode.
* Minor cleanup.

Fixes angular#9273.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 8, 2018
jelbourn
jelbourn approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 10, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 10, 2018
@jelbourn jelbourn merged commit 075464f into angular:master Jan 23, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
@crisbeto @jelbourn
fix(selection-model): incorrect initial value when empty array is pas…
5d0fb95 
…sed in single-selection mode (angular#9287)

* Fixes the selection model being initialized to `[undefined]` when an empty array is passed in as the initial value in single-selection mode.
* Minor cleanup.

Fixes angular#9273.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelectionModel<T> initialized with empty array results in selected.length==1
3 participants
@crisbeto @jelbourn @googlebot