feat(drawer): allow for backdrop to be disabled #9381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Jan 16, 2018
src/lib/sidenav/drawer.ts
Outdated
| return this._hasBackdrop; | ||
| } | ||
| set hasBackdrop(value: any) { | ||
| this._hasBackdrop = coerceBooleanProperty(value); |
There was a problem hiding this comment.
This means that the user can't set it back to it's initial state right (null). I think we should treat null/undefined as null
There was a problem hiding this comment.
Good point. It's changed.
crisbeto
force-pushed
the
5300/drawer-has-backdrop
branch
from
1afee23 to
bf9a73e
Compare
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Jan 16, 2018
Adds the `hasBackdrop` input to the drawer container, allowing users to disable the backdrop. Fixes angular#5300.
crisbeto
force-pushed
the
5300/drawer-has-backdrop
branch
from
bf9a73e to
6d606c2
Compare
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
hasBackdropinput to the drawer container, allowing users to disable the backdrop.Fixes #5300.