Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Code of NINE is wrong #9567

Closed
VangelisAlSghir opened this issue Jan 24, 2018 · 1 comment · Fixed by #9568
Closed

Key Code of NINE is wrong #9567

VangelisAlSghir opened this issue Jan 24, 2018 · 1 comment · Fixed by #9568
Assignees

Comments

@VangelisAlSghir
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

If I call NINE from @angular/cdk/keycodes, I expect 57

What is the current behavior?

If I call NINE from @angular/cdk/keycodes, I get 91

What are the steps to reproduce?

Just compare the table of key codes here: https://www.cambiaresearch.com/articles/15/javascript-char-codes-key-codes

with the key codes here: https://github.com/angular/cdk-builds/blob/master/keycodes/typings/keycodes.d.ts

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?

@devversion devversion self-assigned this Jan 24, 2018
devversion added a commit to devversion/material2 that referenced this issue Jan 24, 2018
* Fixes that the `@angular/cdk/keycodes` package uses a wrong key code for nine.

Fixes angular#9567
jelbourn pushed a commit that referenced this issue Jan 25, 2018
`@angular/cdk/keycodes` package used the wrong key code for nine.

Fixes #9567
jelbourn pushed a commit to jelbourn/components that referenced this issue Jan 29, 2018
`@angular/cdk/keycodes` package used the wrong key code for nine.

Fixes angular#9567
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants