fix(stepper): overriding default completed logic when resetting #9650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something that came up while looking another issue. Currently the stepper supports two ways of determining whether a step is completed: the default one that checks against the passed-in `FormControl` and the custom one where the consumer can pass in a value through the `completed` input. Currently when the stepper is reset via the `reset` method, the step sets the `completed` property which means that for any subsequent runs, that step will always be considered as incomplete. These changes switch to resetting the `completed` input only if it was being used beforehand.
googlebot
added
the
cla: yes
mmalerba
approved these changes
Jan 29, 2018
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that came up while looking another issue. Currently the stepper supports two ways of determining whether a step is completed: the default one that checks against the passed-in
FormControland the custom one where the consumer can pass in a value through thecompletedinput. Currently when the stepper is reset via theresetmethod, the step sets thecompletedproperty which means that for any subsequent runs, that step will always be considered as incomplete. These changes switch to resetting thecompletedinput only if it was being used beforehand.