Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): options inside option group not being rendered when wrapped with ng-container #9769

Merged
merged 1 commit into from
Feb 8, 2018
Merged

fix(select): options inside option group not being rendered when wrapped with ng-container #9769

merged 1 commit into from
Feb 8, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 3, 2018

Fixes the mat-option instances inside of a mat-optgroup not being rendered if they are wrapped inside of a ng-container.

Fixes #9736.

@crisbeto
fix(select): options inside option group not being rendered when wrap…
36744ea 
…ped with ng-container

Fixes the `mat-option` instances inside of a `mat-optgroup` not being rendered if they are wrapped inside of a `ng-container`.

Fixes angular#9736.
@crisbeto crisbeto requested a review from kara as a code owner February 3, 2018 12:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 3, 2018
jelbourn
jelbourn approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 5, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 5, 2018
@mmalerba mmalerba merged commit 6f680d5 into angular:master Feb 8, 2018
mmalerba pushed a commit that referenced this pull request Feb 8, 2018
@crisbeto @mmalerba
fix(select): options inside option group not being rendered when wrap…
38fddfe 
…ped with ng-container (#9769)

Fixes the `mat-option` instances inside of a `mat-optgroup` not being rendered if they are wrapped inside of a `ng-container`.

Fixes #9736.
tinayuangao pushed a commit that referenced this pull request Feb 9, 2018
@crisbeto @tinayuangao
fix(select): options inside option group not being rendered when wrap…
62ca6da 
…ped with ng-container (#9769)

Fixes the `mat-option` instances inside of a `mat-optgroup` not being rendered if they are wrapped inside of a `ng-container`.

Fixes #9736.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-optgroup does not support ng-container child wrapper
4 participants
@crisbeto @jelbourn @googlebot @mmalerba