fix(bottom-sheet): inject correct directionality in child components #9996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Feb 17, 2018
src/lib/bottom-sheet/bottom-sheet.ts
Outdated
| injectionTokens.set(Directionality, { | ||
| value: config.direction, | ||
| change: observableOf() | ||
| }); |
There was a problem hiding this comment.
We should only set this token if there's not already a Directionality in the userInjector
Currently the `MatBottomSheetConfig.direction` property will add the `dir` attribute to the overlay, however that doesn't mean that child components that inject the `Directionality` will be able to pick it up (e.g. sliders, menus etc.). These changes add an extra injection token that'll expose the direction to child components.
crisbeto
force-pushed
the
bottom-sheet-provide-directionality
branch
from
afaad52 to
70bd495
Compare
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 18, 2018
…ready Switches the dialog injector to provide the `Directionality` only when the user-provided injector doesn't have one already. Relates to angular#9996.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 18, 2018
…ready Switches the dialog injector to provide the `Directionality` only when the user-provided injector doesn't have one already. Relates to angular#9996.
tinayuangao
pushed a commit
that referenced
this pull request
Feb 20, 2018
…9996) Currently the `MatBottomSheetConfig.direction` property will add the `dir` attribute to the overlay, however that doesn't mean that child components that inject the `Directionality` will be able to pick it up (e.g. sliders, menus etc.). These changes add an extra injection token that'll expose the direction to child components.
andrewseguin
added
target: minor
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 26, 2018
…ready (angular#10004) Switches the dialog injector to provide the `Directionality` only when the user-provided injector doesn't have one already. Relates to angular#9996.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Feb 27, 2018
…ready (angular#10004) Switches the dialog injector to provide the `Directionality` only when the user-provided injector doesn't have one already. Relates to angular#9996.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
MatBottomSheetConfig.directionproperty will add thedirattribute to the overlay, however that doesn't mean that child components that inject theDirectionalitywill be able to pick it up (e.g. sliders, menus etc.). These changes add an extra injection token that'll expose the direction to child components.