Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): ink bar not visible in high contrast mode #9997

Merged
merged 1 commit into from
Feb 18, 2018
Merged

fix(tabs): ink bar not visible in high contrast mode #9997

merged 1 commit into from
Feb 18, 2018

Conversation

crisbeto
Copy link
Member

Adds a fallback that makes the ink bar visible in high contrast mode, allowing users to see which tab is selected.

@crisbeto
fix(tabs): ink bar not visible in high contrast mode
a1fdf08 
Adds a fallback that makes the ink bar visible in high contrast mode, allowing users to see which tab is selected.
@crisbeto crisbeto added pr: needs review Accessibility This issue is related to accessibility (a11y) labels Feb 17, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 17, 2018
jelbourn
jelbourn approved these changes Feb 17, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 17, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 17, 2018
@jelbourn jelbourn merged commit e24bb42 into angular:master Feb 18, 2018
tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @tinayuangao
fix(tabs): ink bar not visible in high contrast mode (#9997)
a112e80 
Adds a fallback that makes the ink bar visible in high contrast mode, allowing users to see which tab is selected.
andrewseguin pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @andrewseguin
fix(tabs): ink bar not visible in high contrast mode (#9997)
1ba04eb 
Adds a fallback that makes the ink bar visible in high contrast mode, allowing users to see which tab is selected.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@andrewseguin andrewseguin

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin