Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split wrc #458

Merged
merged 3 commits into from
Jun 30, 2018
Merged

Split wrc #458

merged 3 commits into from
Jun 30, 2018

Conversation

tmilnthorp
Copy link
Collaborator

More work towards #409. Creating code generator script for .NET-only code. Using existing script to generate "common" code for both .NET and WRC. Removing #if WINDOWS_UWP from Value property in Common code and moving each to their separate .NET and WCR code generators.

…fic constructor from shared/UnitsNet code. Moving it to WCR code only script.
…ipt to generate "common" code for both .NET and WRC. Removing #if WINDOWS_UWP from Value property in Common code and moving each to their seperate .NET and WCR code generators.
@tmilnthorp
Copy link
Collaborator Author

This is more baby steps FYI. There's a lot more code to pull into the separate implementations for .NET and WRC. It is already a lot of changed files so I didn't want to go too far immediately.

@tmilnthorp
Copy link
Collaborator Author

Ultimately I'd like to move the scripts around to their appropriate folders/projects also. Possibly even move the common script out of the UnitsNet folder and into a "Common" folder (Common\Scripts).

I'd also like to move the generated code directories around a bit to split Common/.NET/WRC into their appropriate folders.

Common\GeneratedCode.
UnitsNet\GeneratedCode
WindowsRuntimeComponent\GeneratedCode

etc.

Trying to do this slowly since it will be large changes!

@angularsen
Copy link
Owner

Consider naming it UnitsNet.Common to distinguish it from say json serialization code.

@angularsen angularsen merged commit 146ee4c into angularsen:master Jun 30, 2018
@angularsen
Copy link
Owner

Awesome, looks good. The phone 📱 struggles with these huge diffs though 😁

@tmilnthorp tmilnthorp deleted the SplitWRC branch July 2, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants