Add QuantityTypeConverter #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I've been way busy lately, but I'll get to review this soon. |
|
Just an update, I intend to look at this soon, things are less busy at work now. |
angularsen
requested changes
Apr 12, 2019
There was a problem hiding this comment.
Phew, this was a big one!
Awesome work on this and great work on all the test cases, it makes it a lot easier to evaluate the implementation.
Please take a look at my feedback and we will take it from there. Please don't hesitate to push back if you don't agree with my suggestions.
Improved XMLdoc
Updated xmldoc
angularsen
requested changes
Apr 22, 2019
Clean up Better description of UnitsNetTypeConverter
angularsen
approved these changes
Apr 29, 2019
|
Very nice, thanks a lot for the big effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#189
Implements TypeConverter for IQuantity