-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create code coverage reports #657
Conversation
Currently getting error messages about not finding .pdb files on AppVeyor, but the same commands work locally when building with https://ci.appveyor.com/project/angularsen/unitsnet/builds/24002213
Links: |
Fixes issue of outdated version in AppVeyor image. Don't want to check in large binaries.
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
=========================================
Coverage ? 55.56%
=========================================
Files ? 164
Lines ? 37408
Branches ? 0
=========================================
Hits ? 20786
Misses ? 16622
Partials ? 0 Continue to review full report at Codecov.
|
Well whoop, it finally works. The numbers are horrible of course, but we'll improve that by either filtering out stuff or converting tests to test for N units. |
Looks good - but yikes. Do you mean that coverage isn't calculated properly until we switch to NUnit from XUnit? |
I didn't mean NUnit :-D I meant going from "hey here is a test case that tests Length, Mass and some other widely used quantities all in one go" to maybe generating unique test cases for every quantity and unit - in order to get better test coverage. But yeah, I'll have to look closer at the numbers. I was mostly happy that I got it working at all as a start :-P |
I'll take a second look at why the numbers are so bad before merging this. |
Secure envvars are not decoded for PRs for public repos.
@tmilnthorp Wohoo! After switching from OpenCover to dotCover I got more sane results and way better performance. 56% coverage now, which sounds reasonable given that many tests only target specific quantities. I believe the licensing for the CLI tooling is OK, but I have also applied for an open source license just to be sure. Merging this now so we can get a baseline going for future PRs. |
Sweet. Still surprised though given all the As/To methods |
Added issue to follow up improving the coverage numbers: |
Testing out codecov.io for test coverage reports on pull requests, with diffs against master.
OpenCoveragedotCover to produce statisticsI tried OpenCoverage first, but I ran into heaps of trouble and it seems the project is not very actively maintained. dotCover CLI tools does not require a license as far as I can tell and is much faster to run.