Fix for negative feet/inch parsing #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, only a failing test case. |
Oops. I put "- 1′ 1″ " when I meant " -1′ 1″ ". Multi-line added the negative sign :) Fixed That said, should "- 1′ 1″ "work? |
|
I don't know, but my intuition tells me we shouldn't have to support something like that. We have been bit previously by trying to be too lenient in parsing all sorts of input. |
angularsen
reviewed
Jul 9, 2019
| [InlineData( "-1 ft 1 in", -1.08333333 )] | ||
| [InlineData( "-1ft 1in", -1.08333333 )] | ||
| [InlineData("-1'", 1)] // Feet only | ||
| [InlineData("-1′", 1)] // Feet only |
There was a problem hiding this comment.
Wait, what? Shouldn't expectedFeet still be negative 1?
There was a problem hiding this comment.
Haha I re-copied-and-pasted. It's been a long day :) fixed
angularsen
approved these changes
Jul 9, 2019
|
Looks good now :-) green tests too! |
|
Would you publish a new release too, please? |
|
Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #673.