Rename constructor argument 'numericalValue' to 'value'

[rohahn]

In a project we would like to serialize quantity objects (e.g. Pressure) with MessagePack for inter-process communication. We don't want to persist the data and all processes will use the same version of Units.NET.

Aligning the name of the constructor argument with the property 'Value' allows MessagePack deserialization of types generated by QuantityGenerator (with some minor changes to MessagePack). MessagePack can deserialize immutable types by passing the deserialized values of properties without a setter to an appropriate constructor.

I did not regenerate the classes in GeneratedCode to keep the changes as small as possible.

[codecov-io]

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   58.25%   58.25%           
=======================================
  Files         166      166           
  Lines       37766    37766           
=======================================
  Hits        22001    22001           
  Misses      15765    15765

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db95ddf...7a408bb. Read the comment docs.

[angularsen]

@tmilnthorp I don't see any problems with this, do you? If it helps some reflection libraries auto-map ctor params to properties then I guess that is a benefit.

@rohahn Just a word of caution that you might be better off mapping to your own types for serialization. We are very likely to introduce breaking changes without increasing the major version, and this PR reflects that situation perfectly (renaming ctor params). See UnitsNet.Serialization.JsonNet project for how we added support for JSON.net serialization by introducing separate, simpler types intended for future proof serialization.

[rohahn]

@angularsen Thanks for the warning. I read some of the discussions about this topic and I am aware of the potential problems. Our current workaround is quite similar and based on a custom resolver and formatter for MessagePack. But since MessagePack is optimized for performance (code generation instead of reflection), we would prefer a solution without custom code in the serialization pipeline. In our case the problem of breaking changes is mitigated, since we control all parts of the system and the serialization is not part of a the public API.

[angularsen]

Very well. This PR needs to merge in latest origin/master to resolve the conflicts.
Also, you should run generate-code.bat to include the changes in generated code in the PR.

[angularsen]

Looks good to me! Nuget on the way out.

Release UnitsNet/4.37.0 · angularsen/UnitsNet