Fix typos #706
Merged
Fix typos #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angularsen
requested changes
Sep 19, 2019
There was a problem hiding this comment.
Please rebase this PR to remove the commit that renames the ctor param, which is included in #705. Other than that, this looks good!
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 58.25% 58.25%
=======================================
Files 166 166
Lines 37766 37766
=======================================
Hits 22001 22001
Misses 15765 15765Continue to review full report at Codecov.
|
|
I rebased the PR. |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some typos in QuantityGenerator