Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AreaMomentOfInertia operator / overload #710

Merged
merged 2 commits into from
Oct 12, 2019
Merged

AreaMomentOfInertia operator / overload #710

merged 2 commits into from
Oct 12, 2019

Conversation

lwestfall
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #710 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   58.32%   58.33%   +<.01%     
==========================================
  Files         166      167       +1     
  Lines       37811    37814       +3     
==========================================
+ Hits        22055    22058       +3     
  Misses      15756    15756
Impacted Files Coverage Δ
...CustomCode/Quantities/AreaMomentOfInertia.extra.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a4723...55960e1. Read the comment docs.

@lwestfall
Copy link
Contributor Author

I'm unsure what I did wrong for the first 4 commits to be included in this PR. I only intended to include the final one "af39705". If I need to do something and resubmit please let me know.

Thanks

@angularsen
Copy link
Owner

angularsen commented Oct 9, 2019

Hey and thanks for contributing. My best guess what happened is that your branch areamomentofinertia-operator-overloads was based on your own master branch, not angularsen repo's master and you had those extra commits from there.

This is how I recommend you fix it with git from console, details may vary depending on how you have it set up locally and if you prefer using git gui tools:

  1. Add angularsen repo as a remote: git remote add angularsen https://github.com/angularsen/UnitsNet
  2. git fetch to download everything
  3. git checkout areamomentofinertia-operator-overloads to checkout your branch locally
  4. git rebase -i angularsen/master to interactively rebase your branch on top of angularsen's master
  5. Delete all lines except the commit you want to keep, it should say pick <commit> <message>, save and exit (if you are using vim editor, type i to enter editing mode, esc to go back to normal mode and type :x in normal mode to save and exit)
  6. git log to verify that you now only have this commit in addition to angularsen/master's commits
  7. git push --force to overwrite your remote branch and effectively update the commits of this PR

Git can be confusing, but I'm happy to help and here are some docs too:
https://help.github.com/en/articles/creating-a-pull-request-from-a-fork
https://help.github.com/en/articles/working-with-forks

@angularsen angularsen merged commit afc73c4 into angularsen:master Oct 12, 2019
@angularsen
Copy link
Owner

Awesome!
Nuget is on the way out.

Release UnitsNet/4.39.0 · angularsen/UnitsNet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants