-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for standard numeric format strings #788
Add support for standard numeric format strings #788
Conversation
@angularsen I suggest we deprecate the following format strings: "V", "v", "S", "s". With this PR I think it makes more sense to use the standard format strings for these, or a custom string.Format on |
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 280 280
Lines 41834 41841 +7
=======================================
+ Hits 32884 32890 +6
- Misses 8950 8951 +1
Continue to review full report at Codecov.
|
@tmilnthorp Hm, I think maybe you are right. I have honestly never used the string format stuff much myself, but I can see how it doesn't really add much value to do |
Getting late so I'll have to revisit this, but are we proposing to support standard numeric formats on our quantities? I mean, we could, but I have a feeling this is not commonly used or a best practice. Why can't the consumer just do |
Being in the category of people who are doing the dual string formatting- I would much prefer the simple "f3" format. My reasons are:
|
|
Note that nothing prevents us from allowing |
@tmilnthorp @pgrawehr Ok, I am convinced. I like the argument that
I forgot to mention, but |
Fixes #786 |
Add support for standard double numeric format strings. Also allow upper case format specifiers.
Fixes #786