Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove anki submodule dependency #14

Closed
VikashKothary opened this issue Jun 26, 2020 · 1 comment
Closed

Remove anki submodule dependency #14

VikashKothary opened this issue Jun 26, 2020 · 1 comment

Comments

@VikashKothary
Copy link
Member

VikashKothary commented Jun 26, 2020 •
edited
Loading

There are a lot of changes. Currently very theoretical.

The anki submodule was needed because at the time of creating this project, there was no way of installing the client. This has not been the case for some time now. It would be a lot easier to just install the anki package from pip.

Potential Action List

  1. Find earliest version of anki deployed to PyPi
  2. Calculate difference between current submodule and anki package.
  3. Patch the difference

Alternative Action

  1. Create a repo for the submodule commit.
  2. Pip install repo
  3. Update repo commit by commit and see where it breaks
@VikashKothary VikashKothary changed the title Update anki submodule to latest release Remove anki submodule dependency Jun 30, 2020
@VikashKothary VikashKothary mentioned this issue Jun 30, 2020
Open
@kalehmann kalehmann mentioned this issue Aug 28, 2020
Merged
2 tasks
@VikashKothary
Copy link
Member Author

This is resolved by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VikashKothary