Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Delete individual search history #14988

Closed
SanjaySargam opened this issue Dec 15, 2023 · 11 comments
Closed

Settings: Delete individual search history #14988

SanjaySargam opened this issue Dec 15, 2023 · 11 comments
Assignees
Labels
Accepted Maintainers welcome a PR implementing this feature Enhancement

Comments

@SanjaySargam
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, we can delete all search history at once. There is no option to delete a particular search history individually

Describe the solution you'd like
Show a dialog box on clicking on a particular search history where user can delete it individually

@SanjaySargam
Copy link
Contributor Author

Working on it

@david-allison

This comment was marked as off-topic.

@david-allison david-allison added this to the 2.17 release milestone Dec 15, 2023
@david-allison david-allison changed the title Implement Feature to delete particular Search History [BUG] Card Browser: Delete 'my searches' entry broken Dec 15, 2023
@david-allison

This comment was marked as off-topic.

@SanjaySargam
Copy link
Contributor Author

@david-allison I'm talking about search history in Setting Screen

@SanjaySargam
Copy link
Contributor Author

I understand the above one is also a valid issue

Should I create a new issue for search history in setting screen

@david-allison david-allison changed the title [BUG] Card Browser: Delete 'my searches' entry broken Settings: Delete individual search history Dec 15, 2023
@david-allison
Copy link
Member

david-allison commented Dec 15, 2023

Ah! You caught a bug anyway, great job!

Best to run this by @BrayanDSO before implementation, since they set the current direction of Settings and likely have plans for where it should go in the future

@david-allison david-allison removed this from the 2.17 release milestone Dec 15, 2023
@BrayanDSO
Copy link
Member

I like the idea. But it's up to the preferences search library maintainer https://github.com/ByteHamster/SearchPreference

My past interactions with them were pretty good, so give it a shot there

@david-allison david-allison added the Accepted Maintainers welcome a PR implementing this feature label Dec 15, 2023
@SanjaySargam
Copy link
Contributor Author

@BrayanDSO
https://github.com/ByteHamster/SearchPreference
You mean I have to make PR in this repo right?

@BrayanDSO
Copy link
Member

Right

@ByteHamster
Copy link
Contributor

Is this really something users would need? What would be use-cases of this? I can totally see how deleting individual history items makes sense for a web browser, but for searching settings...?

To me, this feels like adding features just for the sake of adding them. More like a programming exercise than an actual useful feature that people need. While the additional code complexity isn't too much, it's still additional complexity (translations, testing, etc). The increase in apk size is probably kind of small as well (mainly just translations), but these things add up.

I'm not yet really convinced yet why this is actually something users need. But I'm open to be convinced otherwise.

@BrayanDSO
Copy link
Member

Good point. Agreed. I'm gonna close this issue to focus on more relevant things.

Thanks for the reply, @ByteHamster

@BrayanDSO BrayanDSO closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Maintainers welcome a PR implementing this feature Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants