Settings: Delete individual search history

[SanjaySargam]

Is your feature request related to a problem? Please describe.
Currently, we can delete all search history at once. There is no option to delete a particular search history individually

Describe the solution you'd like
Show a dialog box on clicking on a particular search history where user can delete it individually

[SanjaySargam]

Working on it

[SanjaySargam]

@david-allison I'm talking about search history in Setting Screen

[SanjaySargam]

I understand the above one is also a valid issue

Should I create a new issue for search history in setting screen

[david-allison]

Ah! You caught a bug anyway, great job!

Best to run this by @BrayanDSO before implementation, since they set the current direction of Settings and likely have plans for where it should go in the future

[BrayanDSO]

I like the idea. But it's up to the preferences search library maintainer https://github.com/ByteHamster/SearchPreference

My past interactions with them were pretty good, so give it a shot there

[SanjaySargam]

@BrayanDSO
https://github.com/ByteHamster/SearchPreference
You mean I have to make PR in this repo right?

[BrayanDSO]

Right

[ByteHamster]

Is this really something users would need? What would be use-cases of this? I can totally see how deleting individual history items makes sense for a web browser, but for searching settings...?

To me, this feels like adding features just for the sake of adding them. More like a programming exercise than an actual useful feature that people need. While the additional code complexity isn't too much, it's still additional complexity (translations, testing, etc). The increase in apk size is probably kind of small as well (mainly just translations), but these things add up.

I'm not yet really convinced yet why this is actually something users need. But I'm open to be convinced otherwise.

[BrayanDSO]

Good point. Agreed. I'm gonna close this issue to focus on more relevant things.

Thanks for the reply, @ByteHamster