-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: Delete individual search history #14988
Comments
Working on it |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@david-allison I'm talking about search history in Setting Screen |
I understand the above one is also a valid issue Should I create a new issue for search history in setting screen |
Ah! You caught a bug anyway, great job! Best to run this by @BrayanDSO before implementation, since they set the current direction of |
I like the idea. But it's up to the preferences search library maintainer https://github.com/ByteHamster/SearchPreference My past interactions with them were pretty good, so give it a shot there |
@BrayanDSO |
Right |
Is this really something users would need? What would be use-cases of this? I can totally see how deleting individual history items makes sense for a web browser, but for searching settings...? To me, this feels like adding features just for the sake of adding them. More like a programming exercise than an actual useful feature that people need. While the additional code complexity isn't too much, it's still additional complexity (translations, testing, etc). The increase in apk size is probably kind of small as well (mainly just translations), but these things add up. I'm not yet really convinced yet why this is actually something users need. But I'm open to be convinced otherwise. |
Good point. Agreed. I'm gonna close this issue to focus on more relevant things. Thanks for the reply, @ByteHamster |
Is your feature request related to a problem? Please describe.
Currently, we can delete all search history at once. There is no option to delete a particular search history individually
Describe the solution you'd like
Show a dialog box on clicking on a particular search history where user can delete it individually
The text was updated successfully, but these errors were encountered: