Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should find and connect all causing changes #6

Closed
ankon opened this issue May 12, 2022 · 1 comment
Closed

Should find and connect all causing changes #6

ankon opened this issue May 12, 2022 · 1 comment
Assignees

Comments

@ankon
Copy link
Owner

ankon commented May 12, 2022

It is possible that multiple parameters cause a change in the same resource. These should all be linked, as when reviewing these are very likely also the ones the reviewer looks for.

@ankon ankon self-assigned this May 14, 2022
@ankon ankon closed this as completed in 72d9ff3 May 14, 2022
@ankon
Copy link
Owner Author

ankon commented May 14, 2022

Problem was caused by a combination of things:

  1. We didn't produce unique edge names, as we only used the ChangeSource. We now include the source port and target in the edge name, which should be unique enough.
  2. go-graphviz embeds an old version of graphviz, where the logic for looking up an edge by name was broken (https://gitlab.com/graphviz/graphviz/-/issues/1191). We now use a forked version of go-graphviz, until the issue is fixed there (multi-edges generate error on non-strict digraph goccy/go-graphviz#52, Fixed typo that broke wildcard feature in agedgeidcmpf() goccy/go-graphviz#57)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant