-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fxredis): Provided module #11
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 93.12% 83.33% -9.80%
==========================================
Files 4 1 -3
Lines 131 18 -113
==========================================
- Hits 122 15 -107
+ Misses 6 2 -4
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice !
few comments to check, and I wonder maybe clearer / cleaner to split un 2 funcs the real and mock clients providing, wdyt ?
No description provided.