Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fxredis): Provided module #11

Merged
merged 6 commits into from
Mar 28, 2024
Merged

feat(fxredis): Provided module #11

merged 6 commits into from
Mar 28, 2024

Conversation

Babacooll
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.33%. Comparing base (f22963b) to head (eabd069).

Files Patch % Lines
fxredis/module.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   93.12%   83.33%   -9.80%     
==========================================
  Files           4        1       -3     
  Lines         131       18     -113     
==========================================
- Hits          122       15     -107     
+ Misses          6        2       -4     
+ Partials        3        1       -2     
Flag Coverage Δ
fxgcppubsub ?
fxredis 83.33% <83.33%> (?)
fxslack ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ekkinox ekkinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice !

few comments to check, and I wonder maybe clearer / cleaner to split un 2 funcs the real and mock clients providing, wdyt ?

fxredis/README.md Outdated Show resolved Hide resolved
fxredis/README.md Outdated Show resolved Hide resolved
fxredis/module.go Outdated Show resolved Hide resolved
fxredis/module.go Outdated Show resolved Hide resolved
fxredis/testdata/config/config.yaml Outdated Show resolved Hide resolved
@Babacooll Babacooll requested a review from ekkinox March 28, 2024 11:31
@ekkinox ekkinox merged commit 7af9310 into main Mar 28, 2024
6 checks passed
@ekkinox ekkinox deleted the feat/add-redis-module branch March 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants