From 2eaa92bb14212103294a3672b8f0c8c17c877d30 Mon Sep 17 00:00:00 2001 From: Sean Sullivan Date: Tue, 14 Jan 2025 17:34:08 +0000 Subject: [PATCH 1/3] lag_interfaces - Fix bug where lag interfaces was not erroring on command failure. --- changelogs/fragments/lag_interfaces_error.yaml | 3 +++ .../network/nxos/config/lag_interfaces/lag_interfaces.py | 2 ++ 2 files changed, 5 insertions(+) create mode 100644 changelogs/fragments/lag_interfaces_error.yaml diff --git a/changelogs/fragments/lag_interfaces_error.yaml b/changelogs/fragments/lag_interfaces_error.yaml new file mode 100644 index 000000000..62f7b5dd8 --- /dev/null +++ b/changelogs/fragments/lag_interfaces_error.yaml @@ -0,0 +1,3 @@ +--- +bugfixes: + - "lag_interfaces - Fix bug where lag interfaces was not erroring on command failure." \ No newline at end of file diff --git a/plugins/module_utils/network/nxos/config/lag_interfaces/lag_interfaces.py b/plugins/module_utils/network/nxos/config/lag_interfaces/lag_interfaces.py index fc3202a7f..433a5a950 100644 --- a/plugins/module_utils/network/nxos/config/lag_interfaces/lag_interfaces.py +++ b/plugins/module_utils/network/nxos/config/lag_interfaces/lag_interfaces.py @@ -86,6 +86,8 @@ def execute_module(self): err_str = item if err_str.lower().startswith("cannot add"): self._module.fail_json(msg=err_str) + elif err_str.lower().startswith("command failed"): + self._module.fail_json(msg=err_str) result["changed"] = True if self.state in self.ACTION_STATES: From 3eee40492da49a3e0c181767c3da83b353ff782d Mon Sep 17 00:00:00 2001 From: Sean Sullivan Date: Tue, 14 Jan 2025 17:35:43 +0000 Subject: [PATCH 2/3] linting --- changelogs/fragments/lag_interfaces_error.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/lag_interfaces_error.yaml b/changelogs/fragments/lag_interfaces_error.yaml index 62f7b5dd8..09fed342f 100644 --- a/changelogs/fragments/lag_interfaces_error.yaml +++ b/changelogs/fragments/lag_interfaces_error.yaml @@ -1,3 +1,3 @@ --- bugfixes: - - "lag_interfaces - Fix bug where lag interfaces was not erroring on command failure." \ No newline at end of file + - "lag_interfaces - Fix bug where lag interfaces was not erroring on command failure." From 3b56443b5683b6a0b3a4184c709f193984776916 Mon Sep 17 00:00:00 2001 From: Sean Sullivan Date: Tue, 14 Jan 2025 17:42:00 +0000 Subject: [PATCH 3/3] added pr to changelog --- changelogs/fragments/lag_interfaces_error.yaml | 2 +- galaxy.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changelogs/fragments/lag_interfaces_error.yaml b/changelogs/fragments/lag_interfaces_error.yaml index 09fed342f..bb607bd58 100644 --- a/changelogs/fragments/lag_interfaces_error.yaml +++ b/changelogs/fragments/lag_interfaces_error.yaml @@ -1,3 +1,3 @@ --- bugfixes: - - "lag_interfaces - Fix bug where lag interfaces was not erroring on command failure." + - "lag_interfaces - Fix bug where lag interfaces was not erroring on command failure. (https://github.com/ansible-collections/cisco.nxos/pull/923)" diff --git a/galaxy.yml b/galaxy.yml index 494fdf171..c5d8ff2a8 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -10,4 +10,4 @@ readme: README.md repository: https://github.com/ansible-collections/cisco.nxos issues: https://github.com/ansible-collections/cisco.nxos/issues tags: [cisco, nxos, networking, nxapi, netconf] -version: 9.2.1 +version: 9.2.2-devel