maven_artifact: Convert MD5 values to lowercase before comparison (#197)

Fixes: #186 Signed-off-by: Abhijeet Kasurde <[email protected]>
ansible-collections · Apr 17, 2020 · 2639d4c · 2639d4c
1 parent 406d325
commit 2639d4c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelogs/fragments/186-maven_artifact.yml b/changelogs/fragments/186-maven_artifact.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- Convert MD5SUM to lowercase before comparison in maven_artifact module (https://github.com/ansible-collections/community.general/issues/186).
diff --git a/plugins/modules/packaging/language/maven_artifact.py b/plugins/modules/packaging/language/maven_artifact.py
@@ -519,12 +519,12 @@ def is_invalid_md5(self, file, remote_url):
                 remote_md5 = _remote_md5
                 # remote_md5 is empty so we continue and keep original md5 string
                 # This should not happen since we check for remote_md5 before
-            except IndexError as e:
+            except IndexError:
                 pass
-            if local_md5 == remote_md5:
+            if local_md5.lower() == remote_md5.lower():
                 return None
             else:
-                return "Checksum does not match: we computed " + local_md5 + "but the repository states " + remote_md5
+                return "Checksum does not match: we computed " + local_md5 + " but the repository states " + remote_md5
 
         return "Path does not exist: " + file
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- Convert MD5SUM to lowercase before comparison in maven_artifact module (https://github.com/ansible-collections/community.general/issues/186).