Replace missing default favicon with docs.ansible.com favicon (#5928)

* replace missing default favicon with docs.ansible.com * create changelog fragment for PR 5928 * move changelog fragment * fix parameter description Co-authored-by: Felix Fontein <[email protected]> * fix parameter description Co-authored-by: Felix Fontein <[email protected]> * add affected modules in changelog fragment Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Lars Krahl <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit a64df65)
ansible-collections · Feb 3, 2023 · 83813a3 · 83813a3
1 parent 5d5d403
commit 83813a3
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/changelogs/fragments/5928-fix-favicon-url.yml b/changelogs/fragments/5928-fix-favicon-url.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - mattermost, rocketchat, slack - replace missing default favicon with docs.ansible.com favicon (https://github.com/ansible-collections/community.general/pull/5928).
diff --git a/plugins/modules/mattermost.py b/plugins/modules/mattermost.py
@@ -60,8 +60,8 @@
   icon_url:
     type: str
     description:
-      - Url for the message sender's icon.
-    default: https://www.ansible.com/favicon.ico
+      - URL for the message sender's icon.
+    default: https://docs.ansible.com/favicon.ico
   validate_certs:
     description:
       - If C(false), SSL certificates will not be validated. This should only be used
@@ -127,7 +127,7 @@ def main():
             text=dict(type='str'),
             channel=dict(type='str', default=None),
             username=dict(type='str', default='Ansible'),
-            icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
+            icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
             validate_certs=dict(default=True, type='bool'),
             attachments=dict(type='list', elements='dict'),
         ),

diff --git a/plugins/modules/rocketchat.py b/plugins/modules/rocketchat.py
@@ -58,7 +58,7 @@
     type: str
     description:
       - URL for the message sender's icon.
-    default: "https://www.ansible.com/favicon.ico"
+    default: "https://docs.ansible.com/favicon.ico"
   icon_emoji:
     type: str
     description:
@@ -212,7 +212,7 @@ def main():
             msg=dict(type='str', required=False),
             channel=dict(type='str'),
             username=dict(type='str', default='Ansible'),
-            icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
+            icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
             icon_emoji=dict(type='str'),
             link_names=dict(type='int', default=1, choices=[0, 1]),
             validate_certs=dict(default=True, type='bool'),

diff --git a/plugins/modules/slack.py b/plugins/modules/slack.py
@@ -81,8 +81,8 @@
   icon_url:
     type: str
     description:
-      - Url for the message sender's icon (default C(https://www.ansible.com/favicon.ico))
-    default: https://www.ansible.com/favicon.ico
+      - URL for the message sender's icon (default C(https://docs.ansible.com/favicon.ico))
+    default: https://docs.ansible.com/favicon.ico
   icon_emoji:
     type: str
     description:
@@ -439,7 +439,7 @@ def main():
             channel=dict(type='str'),
             thread_id=dict(type='str'),
             username=dict(type='str', default='Ansible'),
-            icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
+            icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
             icon_emoji=dict(type='str'),
             link_names=dict(type='int', default=1, choices=[0, 1]),
             parse=dict(type='str', choices=['none', 'full']),

diff --git a/tests/unit/plugins/modules/test_slack.py b/tests/unit/plugins/modules/test_slack.py
@@ -142,7 +142,7 @@ def test_message_with_blocks(self):
                 },
                 'accessory': {
                     'type': 'image',
-                    'image_url': 'https://www.ansible.com/favicon.ico',
+                    'image_url': 'https://docs.ansible.com/favicon.ico',
                     'alt_text': 'test'
                 }
             }, {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		minor_changes:
		- mattermost, rocketchat, slack - replace missing default favicon with docs.ansible.com favicon (https://github.com/ansible-collections/community.general/pull/5928).