Skip to content

Commit

Permalink
Remove some comments that won’t be addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
samdoran committed Nov 4, 2022
1 parent 1f96628 commit 91e1283
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions plugins/lookup/onepassword.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ def get_current_version(cls):


class OnePassCLIv1(OnePassCLIBase):
# TODO: Should supports_version be a tuple?
supports_version = "1"

def _parse_field(self, data_json, field_name, section_title):
Expand Down Expand Up @@ -320,7 +319,7 @@ def get_raw(self, item_id, vault=None, token=None):
args += ["--vault={0}".format(vault)]

if token is not None:
args += [to_bytes("--session=") + token] # FIXME: Why is only this bytes?
args += [to_bytes("--session=") + token]

return self._run(args)

Expand Down Expand Up @@ -519,7 +518,7 @@ def get_raw(self, item_id, vault=None, token=None):
if vault is not None:
args += ["--vault={0}".format(vault)]
if token is not None:
args += [to_bytes("--session=") + token] # FIXME: Why is only this bytes?
args += [to_bytes("--session=") + token]

return self._run(args)

Expand Down Expand Up @@ -548,7 +547,6 @@ def __init__(self, subdomain=None, domain="1password.com", username=None, secret
self._cli = self._get_cli_class()

def _get_cli_class(self):
# TODO: When we get a new op version, warn but use the latest class
version = OnePassCLIBase.get_current_version()
for cls in OnePassCLIBase.__subclasses__():
if cls.supports_version == version.split(".")[0]:
Expand Down

0 comments on commit 91e1283

Please sign in to comment.