passwordstore: Fix error detection for non-English locales (#4219)

The passwordstore lookup plugin depends on parsing GnuPG's error messages in English language. As a result, detection of a specific error failes when users set a different locale. This change corrects this by setting the `LANGUAGE` environment variable to `C` when invoking `pass`, as this only affects gettext translations. See https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html (cherry picked from commit 77a0c13)
ansible-collections · Feb 17, 2022 · d4bd2fa · d4bd2fa
1 parent 271bafb
commit d4bd2fa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/changelogs/fragments/4219-passwordstore-locale-fix.yml b/changelogs/fragments/4219-passwordstore-locale-fix.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - passwordstore lookup plugin - fix error detection for non-English locales (https://github.com/ansible-collections/community.general/pull/4219).
diff --git a/plugins/lookup/passwordstore.py b/plugins/lookup/passwordstore.py
@@ -229,6 +229,7 @@ def parse_params(self, term):
 
             # Collect pass environment variables from the plugin's parameters.
             self.env = os.environ.copy()
+            self.env['LANGUAGE'] = 'C'  # make sure to get errors in English as required by check_output2
 
             # Set PASSWORD_STORE_DIR
             if os.path.isdir(self.paramvals['directory']):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- passwordstore lookup plugin - fix error detection for non-English locales (https://github.com/ansible-collections/community.general/pull/4219).