Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zuul tests always fail #402

Closed
felixfontein opened this issue May 22, 2020 · 12 comments
Closed

Zuul tests always fail #402

felixfontein opened this issue May 22, 2020 · 12 comments
Labels
bug This issue/PR relates to a bug has_pr

Comments

@felixfontein
Copy link
Collaborator

SUMMARY

They don't install the required collections.

Please ignore these errors in CI until they are fixed!

CC @gundalow @Andersson007 @Akasurde @abadger

ISSUE TYPE
  • Bug Report
COMPONENT NAME

CI

ANSIBLE VERSION
devel
@ansibullbot
Copy link
Collaborator

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@goneri
Copy link
Member

goneri commented Jun 2, 2020

I see this error in the job output:

b'ERROR! module community.general.kubevirt_vm missing  documentation (or  could not  parse documentation): unknown doc_fragment(s) in file /tmp/tmpaspeeglr/ansible_collections/community/general/plugins/modules/kubevirt_vm.py: community.kubernetes.k8s_auth_options\n

@felixfontein
Copy link
Collaborator Author

@goneri that's because the zuul tests do not install required collection dependencies.

@goneri
Copy link
Member

goneri commented Jun 2, 2020

@felixfontein where is this dependency documented?

@felixfontein
Copy link
Collaborator Author

@goneri
Copy link
Member

goneri commented Jun 2, 2020

Oh, my bad. Thanks.

goneri added a commit to goneri/project-config that referenced this issue Jun 2, 2020
A collection import test may fail if the are not installed.
We now install the collections locally, this way `ansible-galaxy` will
pull the depdendencies for us.

See: ansible-collections/community.general#402
goneri added a commit to goneri/project-config that referenced this issue Jun 2, 2020
A collection import test may fail if the are not installed.
We now install the collections locally, this way `ansible-galaxy` will
pull the depdendencies for us.

`ignore_errors: yes` to avoid any breakage in case of problem. This will
be removed later.

See: ansible-collections/community.general#402
@pabelanger
Copy link

Late to the game, issue here, is going to quickly run into cross-project dependencies on documentation. Which means, for even to publish a collection, you now need to make sure documentation in k8s collection is valid.

IMO, the better way to do this, is disable the ability for galaxy-importer to check for docs outside of a collection. Enforcing a hard dependency between 2 projects, that are not managed by same team is complicated.

goneri added a commit to goneri/project-config that referenced this issue Jun 2, 2020
A collection import test may fail if the are not installed.
We now install the collections locally, this way `ansible-galaxy` will
pull the depdendencies for us.

See: ansible-collections/community.general#402
@pabelanger
Copy link

okay, I've reverted the galaxy-importer change, build-ansible-collections now works. However, imports into galaxy will still fail. Today I'll create ansible-galaxy-importer job, which will install the required dependencies for each collection now.

@felixfontein
Copy link
Collaborator Author

@pabelanger do you mean galaxy right now cannot import collections that use doc fragments (or module_utils) from other collections? That would be a pretty huge bug. Do you know if an issue exists for that?

@pabelanger
Copy link

I don't know, we'll have to tag a release again to see. Last we tried, it was blocked on galaxy-importer, why we added it to the build collection job. Which, caused another issue.

We'll know more by tomorrow, once the new job is up and running.

@felixfontein
Copy link
Collaborator Author

It looks like this is fixed now: the tests for #382 completely passed!

@felixfontein
Copy link
Collaborator Author

@pabelanger thanks a lot for fixing this!

@gundalow gundalow unpinned this issue Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug has_pr
Projects
None yet
Development

No branches or pull requests

4 participants