-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zuul tests always fail #402
Comments
Files identified in the description: If these files are inaccurate, please update the |
I see this error in the job output:
|
@goneri that's because the zuul tests do not install required collection dependencies. |
@felixfontein where is this dependency documented? |
Oh, my bad. Thanks. |
A collection import test may fail if the are not installed. We now install the collections locally, this way `ansible-galaxy` will pull the depdendencies for us. See: ansible-collections/community.general#402
A collection import test may fail if the are not installed. We now install the collections locally, this way `ansible-galaxy` will pull the depdendencies for us. `ignore_errors: yes` to avoid any breakage in case of problem. This will be removed later. See: ansible-collections/community.general#402
Late to the game, issue here, is going to quickly run into cross-project dependencies on documentation. Which means, for even to publish a collection, you now need to make sure documentation in k8s collection is valid. IMO, the better way to do this, is disable the ability for galaxy-importer to check for docs outside of a collection. Enforcing a hard dependency between 2 projects, that are not managed by same team is complicated. |
A collection import test may fail if the are not installed. We now install the collections locally, this way `ansible-galaxy` will pull the depdendencies for us. See: ansible-collections/community.general#402
okay, I've reverted the galaxy-importer change, build-ansible-collections now works. However, imports into galaxy will still fail. Today I'll create ansible-galaxy-importer job, which will install the required dependencies for each collection now. |
@pabelanger do you mean galaxy right now cannot import collections that use doc fragments (or module_utils) from other collections? That would be a pretty huge bug. Do you know if an issue exists for that? |
I don't know, we'll have to tag a release again to see. Last we tried, it was blocked on galaxy-importer, why we added it to the build collection job. Which, caused another issue. We'll know more by tomorrow, once the new job is up and running. |
It looks like this is fixed now: the tests for #382 completely passed! |
@pabelanger thanks a lot for fixing this! |
SUMMARY
They don't install the required collections.
Please ignore these errors in CI until they are fixed!
CC @gundalow @Andersson007 @Akasurde @abadger
ISSUE TYPE
COMPONENT NAME
CI
ANSIBLE VERSION
The text was updated successfully, but these errors were encountered: