Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1Password lookup is broken with cli v2 #4396

Closed
1 task done
duczen opened this issue Mar 24, 2022 · 5 comments · Fixed by #4728
Closed
1 task done

1Password lookup is broken with cli v2 #4396

duczen opened this issue Mar 24, 2022 · 5 comments · Fixed by #4728
Labels
bug This issue/PR relates to a bug

Comments

@duczen
Copy link

duczen commented Mar 24, 2022

Summary

1Password recently updated their cli to v2 and that brings with it breaking changes - lookups are failing with Unable to sign in to 1Password. master_password is required when authenticated and op cli commands return results successfully otherwise.

So far I have noticed a couple changes/issues:

Issue Type

Bug Report

Component Name

1Password lookup

Ansible Version

ansible [core 2.12.3]
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.10/site-packages/ansible
  ansible collection location = /home/user/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/bin/ansible
  python version = 3.10.2 (main, Jan 15 2022, 19:56:27) [GCC 11.1.0]
  jinja version = 3.0.3
  libyaml = True

Community.general Version

community.general 4.6.0

Configuration

No response

OS / Environment

Arch

Steps to Reproduce

Update to 1password cli v2 and attempt to use a 1password lookup after authenticating with op signin

lookup('onepassword', 'some_item', field='some_field', vault='some_vault')

Expected Results

Get secrets from 1password

Actual Results

Got errors due to changes in cli commands and config paths

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the bug This issue/PR relates to a bug label Mar 24, 2022
@felixfontein
Copy link
Collaborator

!component =plugins/lookup/onepassword.py

@felixfontein
Copy link
Collaborator

!component +plugins/lookup/onepassword_raw.py

@ansibullbot
Copy link
Collaborator

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants