Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rax* modules use long-deprecated pyrax package #5648

Closed
1 task done
russoz opened this issue Dec 4, 2022 · 8 comments
Closed
1 task done

rax* modules use long-deprecated pyrax package #5648

russoz opened this issue Dec 4, 2022 · 8 comments
Labels
bug This issue/PR relates to a bug cloud module module plugins plugin (any type)

Comments

@russoz
Copy link
Collaborator

russoz commented Dec 4, 2022

Summary

All 26 plugins/modules/rax*.py modules rely on the pyrax library, however it has been deprecated by the maintainers in 2017, see:

This issue is being raised to make a decision on how to handle this situation. Personally I think we should deprecate these modules, but would like to hear from the other maintainers.

Issue Type

Bug Report

Component Name

plugins/modules/rax_cbs_attachments.py
plugins/modules/rax_cbs.py
plugins/modules/rax_cdb_database.py
plugins/modules/rax_cdb.py
plugins/modules/rax_cdb_user.py
plugins/modules/rax_clb_nodes.py
plugins/modules/rax_clb.py
plugins/modules/rax_clb_ssl.py
plugins/modules/rax_dns.py
plugins/modules/rax_dns_record.py
plugins/modules/rax_facts.py
plugins/modules/rax_files_objects.py
plugins/modules/rax_files.py
plugins/modules/rax_identity.py
plugins/modules/rax_keypair.py
plugins/modules/rax_meta.py
plugins/modules/rax_mon_alarm.py
plugins/modules/rax_mon_check.py
plugins/modules/rax_mon_entity.py
plugins/modules/rax_mon_notification_plan.py
plugins/modules/rax_mon_notification.py
plugins/modules/rax_network.py
plugins/modules/rax.py
plugins/modules/rax_queue.py
plugins/modules/rax_scaling_group.py
plugins/modules/rax_scaling_policy.py

Ansible Version

$ ansible --version
ansible [core 2.13.6]
  config file = None
  configured module search path = ['/home/az/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/az/.local/share/virtualenvs/ansible-collections__community.general-TVemac3D/lib/python3.9/site-packages/ansible
  ansible collection location = /home/az/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/az/.local/share/virtualenvs/ansible-collections__community.general-TVemac3D/bin/ansible
  python version = 3.9.5 (default, Nov 23 2021, 15:27:38) [GCC 9.3.0]
  jinja version = 3.1.2
  libyaml = True

Community.general Version

main branch (devel)

Configuration

No response

OS / Environment

No response

Steps to Reproduce

Expected Results

Actual Results

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud module module plugins plugin (any type) labels Dec 4, 2022
@felixfontein
Copy link
Collaborator

On the other hand, there is some activity in the pyrax repo: https://github.com/pycontribs/pyrax/commits/master
I have no idea how to interpret that...

@smashwilson
Copy link

I would agree with deprecating these. It's been six years since I was at Rackspace, so I don't know who would be in a position to adopt maintenance.

@felixfontein
Copy link
Collaborator

Assuming nobody wants to update them, how about:

  1. Prepare a PR for main to deprecate these modules (to be released in c.g 7.0.0, modules to be removed in c.g 9.0.0);
  2. Announce planned deprecation in c.g 6.x.0 changelog and The Bullhorn, with call to action (something like "if you want that these modules are kept, we are looking for volunteers to maintain them!").

@russoz
Copy link
Collaborator Author

russoz commented Jan 3, 2023

Created PRs #5733 and #5752

@russoz
Copy link
Collaborator Author

russoz commented Apr 2, 2023

Both PRs have been merged, closing this issue.

Thanks @felixfontein @smashwilson for reviewing.

@russoz russoz closed this as completed Apr 2, 2023
@felixfontein
Copy link
Collaborator

FYI, #8198 does the actual removal. It'll likely get merged tomorrow, or the day after. A big thanks to everyone who was involved in these module and helped supporting them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug cloud module module plugins plugin (any type)
Projects
None yet
Development

No branches or pull requests

4 participants