Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONHOLD] Tidyup deprecations #110

Closed
wants to merge 1 commit into from
Closed

[ONHOLD] Tidyup deprecations #110

wants to merge 1 commit into from

Conversation

gundalow
Copy link
Contributor

@gundalow gundalow commented Apr 3, 2020

SUMMARY

  • Collections don't use a leading _ for deprecation, they use
    routing.yml instead
  • Remove left over network entries
  • Remove entries which have gone into collections already

Requires ansible/ansible#68646 before being merged

ISSUE TYPE
  • Bugfix Pull Request

* Collections don't use a leading `_` for deprecation, they use
routing.yml instead
* Remove left over network entries
@gundalow gundalow requested a review from felixfontein April 3, 2020 11:51
vultr_account_facts.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this now a broken link, that you've deleted vultr_account_facts.py?

@ansibullbot
Copy link
Collaborator

@gundalow Please create a new PR using a branch in your fork.

@ansibullbot ansibullbot closed this Apr 9, 2020
@felixfontein
Copy link
Collaborator

@gundalow I guess you need to re-create this PR :)

@gundalow
Copy link
Contributor Author

Moved to #195

@felixfontein felixfontein deleted the tidyup-deprecations branch June 13, 2020 07:17
amenzhinsky pushed a commit to amenzhinsky/community.general that referenced this pull request Nov 13, 2020
adds secure_password property - fixes ansible-collections#110
updates notes
updates readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants