Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslogger: new parameter 'ident' #340

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

Akasurde
Copy link
Member

SUMMARY

Added new parameter ident to specify the name of application
which is sending the message to syslog using syslogger module.

Fixes: #319

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/319-syslogger.yml
plugins/modules/notification/syslogger.py

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug module module labels May 14, 2020
@ansibullbot ansibullbot added has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels May 14, 2020
Added new parameter ident to specify the name of application
which is sending the message to syslog using syslogger module.

Fixes: ansible-collections#319

Signed-off-by: Abhijeet Kasurde <[email protected]>
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 15, 2020
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde merged commit 58ed77e into ansible-collections:master May 15, 2020
@Akasurde Akasurde deleted the i319 branch May 15, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug has_issue module module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow one to override the hardcoded value "ansible_syslogger" in the syslogger module.
3 participants